michael-s-molina commented on pull request #15121: URL: https://github.com/apache/superset/pull/15121#issuecomment-859830694
@geido First thoughts: - You can rename `AntdSelect` and `AntSelect.stories` to `Select` and `Select.stories` using the `index` to resolve any name conflicts. - I think it would be nice to simulate a service API for the storybook. We can support search, pagination and also throw errors to test the error handling. - You can use React `useReducer` to manipulate multiple state values if the number of states increases. - Replace `handleOnDeselect = (option: any)` with `handleOnDeselect = (value: string | number | AntdLabeledValue)` - Replace `handleOnSelect = (option: any)` with `handleOnSelect = (value: string | number | AntdLabeledValue)` - It would be nice to add one Select on each corner of the viewport on the storybook page. Then we can test the drop-down behavior for each corner and when scrolling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
