xiezhongfu opened a new pull request #15139:
URL: https://github.com/apache/superset/pull/15139


   ### SUMMARY
   Semantic name from `toggle fullscreen` to `Enter fullscreen` and `Exit 
fullscreen`.
   
   ### BEFORE/AFTER ANIMATED GIF
   **before**
   ![toggle 
fullscreen2](https://user-images.githubusercontent.com/10264972/121808905-44b37a00-cc8d-11eb-844a-ab7777d54537.gif)
   
   **after**
   ![toggle 
fullscreen](https://user-images.githubusercontent.com/10264972/121808837-f69e7680-cc8c-11eb-9ddf-73f6f62afb0e.gif)
   
   
   ### TESTING INSTRUCTIONS
   * Go to dashboard 3 dot menu, click `Enter fullscreen`
   * After dashboard become fullscreen, click on 3 dot menu again
   * Observe the last option `Exit fullscreen` to toggle back to normal screen
   
   ### ADDITIONAL INFORMATION
   issue: https://github.com/apache/superset/issues/15110
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to