graceguo-supercat commented on pull request #14933: URL: https://github.com/apache/superset/pull/14933#issuecomment-860168672
In airbnb we didn't enable dashboard native filters feature flag, but because of this PR, all the recent visited dashboard were set ``` "show_native_filters": true, "native_filter_configuration": [], ``` This is not the right state. - For dashboard doesn't enable native filters, it should not have above properties in the json_metadata. - When dashboard native filter feature is enabled, `"native_filter_configuration": []` means dashboard didn't have any filter component. This difference is critical for dashboard filter_box migration work. Please check [ SIP-64](https://github.com/apache/superset/issues/14383) "airbnb users" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
