[GitHub] [superset] hughhhh opened a new pull request #15150: fix(db-connection-ui): Additional Query Parameters render

[GitBox]

hughhhh opened a new pull request #15150:
URL: https://github.com/apache/superset/pull/15150


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Fix rendering the query parameters on edit. Before the field would render an 
object instead of the query params formatted.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   #### Before
   <img width="481" alt="Screen Shot 2021-06-14 at 11 26 35 AM" 
src="https://user-images.githubusercontent.com/27827808/121917720-64858500-cd03-11eb-9344-c6f692bed599.png";>
   
   #### After
   <img width="476" alt="Screen Shot 2021-06-14 at 11 27 55 AM" 
src="https://user-images.githubusercontent.com/27827808/121917939-94cd2380-cd03-11eb-9e59-dc1f495d216d.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   1. Goto Database page
   2. Click edit on datebase with dynamic form setting
   3. if empty, add query param (sslmode=disable)
   4. Click Connect
   5. Click on same database, and see the additional parameter render in field.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org