betodealmeida opened a new pull request #15155: URL: https://github.com/apache/superset/pull/15155
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> The `validate_parameters` endpoint was not performing the DB-specific Marshmallow validation (based on `parameters_schema`), but only the validation from the `validate_parameters` schema in the DB engine spec (which does more deep validation like checking if the host is resolvable and the port is open, but doesn't validate the schema). I changed the `DatabaseValidateParametersSchema` schema validation to also validate the DB-specific parameters, and changed the API to return the error messages expected by the frontend for the `onBlur` validation (with an `invalid` key in the `extra`). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Added unit tests. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
