betodealmeida commented on a change in pull request #15155:
URL: https://github.com/apache/superset/pull/15155#discussion_r651373067
##########
File path: tests/databases/api_tests.py
##########
@@ -1733,6 +1744,77 @@ def test_validate_parameters_missing_fields(self):
]
}
+ @mock.patch("superset.db_engine_specs.base.is_hostname_valid")
+ @mock.patch("superset.db_engine_specs.base.is_port_open")
+ @mock.patch("superset.databases.api.ValidateDatabaseParametersCommand")
+ def test_validate_parameters_valid_payload(
+ self, ValidateDatabaseParametersCommand, is_port_open,
is_hostname_valid
+ ):
+ is_hostname_valid.return_value = True
+ is_port_open.return_value = True
+
+ self.login(username="admin")
+ url = "api/v1/database/validate_parameters"
+ payload = {
+ "engine": "postgresql",
+ "parameters": defaultdict(dict),
+ }
+ payload["parameters"].update(
+ {
+ "host": "localhost",
+ "port": 6789,
+ "username": "superset",
+ "password": "XXX",
+ "database": "test",
+ "query": {},
+ }
+ )
+ rv = self.client.post(url, json=payload)
+ response = json.loads(rv.data.decode("utf-8"))
+
+ assert rv.status_code == 200
+ assert response == {"message": "OK"}
+
+ def test_validate_parameters_invalid_port(self):
Review comment:
https://github.com/apache/superset/pull/15151/files#diff-2e62d64ef1113e48efdfeb2acbaa522fca13e49e6a00c2cfd4f74efc4ae1b45cR1314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
