villebro opened a new pull request #15173:
URL: https://github.com/apache/superset/pull/15173


   ### SUMMARY
   One of the example calendar heatmap charts has incorrectly defined the 
`metric` control value, while it really should be `metrics` (the value should 
also be an array of strings, not a string).
   
   ### BEFORE
   
![image](https://user-images.githubusercontent.com/33317356/122042464-da145280-cde2-11eb-8133-269da44b95ee.png)
   
   ### AFTER
   
![image](https://user-images.githubusercontent.com/33317356/122042388-c2d56500-cde2-11eb-9364-7b2968d145c6.png)
   
   ### TESTING INSTRUCTIONS
   1. Populate examples data
   2. Open the "Calendar Heatmap" chart
   3. See that previously it didn't work, but after the changes it works 
properly.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to