villebro opened a new pull request #15247:
URL: https://github.com/apache/superset/pull/15247


   ### SUMMARY
   This adds support for Jinja templating to calculated columns and SQL 
metrics. The PR also adds `TypedDict` types for adhoc metrics to improve code 
quality and linting.
   
   ### BEFORE
   Before Jinja was not processed in calculated columns nor SQL metrics
   
![image](https://user-images.githubusercontent.com/33317356/122511144-79b62880-d00f-11eb-9c09-b2a8a9f91d77.png)
   
![image](https://user-images.githubusercontent.com/33317356/122510971-2e9c1580-d00f-11eb-86aa-2e93e840bc52.png)
   
   ### AFTER
   Now Jinja in both calculated columns and SQL metrics are processed correctly:
   
![image](https://user-images.githubusercontent.com/33317356/122510834-f694d280-d00e-11eb-8c0f-3a78b70f3ec5.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to