hughhhh commented on a change in pull request #15242:
URL: https://github.com/apache/superset/pull/15242#discussion_r654039051
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -596,10 +598,32 @@ const DatabaseModal:
FunctionComponent<DatabaseModalProps> = ({
}
}, [availableDbs]);
+ useEffect(() => {
Review comment:
We don't need this useEffect, we can just key on `validationErrors` to
show the alert
{
validationErrors && <Alert/>
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
