pkdotson commented on a change in pull request #15240:
URL: https://github.com/apache/superset/pull/15240#discussion_r654863675
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -842,10 +842,15 @@ class DatasourceEditor extends React.PureComponent {
{this.allowEditSource && (
<EditLockContainer>
<span role="button" tabIndex={0} onClick={this.onChangeEditMode}>
- <Icon
- color={supersetTheme.colors.grayscale.base}
- name={this.state.isEditMode ? 'lock-unlocked' : 'lock-locked'}
- />
+ {this.state.isEditMode ? (
+ <Icons.LockUnlocked
+ iconColor={supersetTheme.colors.grayscale.base}
Review comment:
I'm going to do this in a follow up (after icons migration) and get rid
of all the supersetThemes being used in components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
