aseembansal-gogo opened a new issue #15293:
URL: https://github.com/apache/superset/issues/15293


   ### Expected results
   
   Labels (inclusive/exclusive) should match actual time range shown.
   
   ### Actual results
   
   Labels (inclusive/exclusive) do not match actual time range shown.
   
   
   #### Screenshots
   
   
![image](https://user-images.githubusercontent.com/69132220/122903904-7901f700-d36d-11eb-8249-a7ce5937daa8.png)
   
   #### How to reproduce the bug
   
   1. Go to Charts
   2. Try to create a table chart on a database which has a date type column
   3. Use time range filter 
   4. Select Custom option
   5. Ensure options match screenshot
   6. Notice that labels say "START (INCLUSIVE)", "END (EXCLUSIVE) " but actual 
time range says `2021-06-14 < col ≤ 2021-06-21` which is contradicting the 
labels
   
   ### Environment
   
   Running inside superset docker container
   
   - superset version: 1.1.0
   - python version: Python 3.7.9
   - node.js version: node: command not found (As the Dockerfile is copying 
from node container I don't expect this to be present so this does not look 
like an issue)
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   Digging into the code I see a problem
   
   It looks like the labels and tool-tip is hard-coded 
https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/controls/DateFilterControl/components/AdvancedFrame.tsx#L64
 but the Actual time range is not 
https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/controls/DateFilterControl/utils/dateFilterUtils.ts#L37
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to