[GitHub] [superset] pkdotson opened a new pull request #15306: refactor: Icon to icons for cerftifiedIcon

[GitBox]

pkdotson opened a new pull request #15306:
URL: https://github.com/apache/superset/pull/15306


   ### SUMMARY
   This pr refactors the certifiedIcon to icon to icons
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before
   <img width="1052" alt="SQL expression" 
src="https://user-images.githubusercontent.com/17326228/122992132-a5f8de80-d35a-11eb-8f9d-ede6e93420b3.png";>
   <img width="374" alt="SEE TABLE SCHEMA 67 IN INFORMATION_SCHEMA" 
src="https://user-images.githubusercontent.com/17326228/122992142-a85b3880-d35a-11eb-8e85-4bd0cd0c78cd.png";>
   <img width="1544" alt="Database" 
src="https://user-images.githubusercontent.com/17326228/122992157-aabd9280-d35a-11eb-80b4-63c95c5566b9.png";>
   
   After
   
   <img width="1541" alt="Database" 
src="https://user-images.githubusercontent.com/17326228/122992173-b01add00-d35a-11eb-8479-2bedb5f1ce82.png";>
   <img width="863" alt="sum(SP_POP_T0TL)" 
src="https://user-images.githubusercontent.com/17326228/122992182-b1e4a080-d35a-11eb-9217-23d60bb400ac.png";>
   <img width="378" alt="SEE TABLE SCHEMA 67 ININFORMATION_SCHEMA" 
src="https://user-images.githubusercontent.com/17326228/122992191-b3ae6400-d35a-11eb-8833-4ab8b3069b27.png";>
   
   ### TESTING INSTRUCTIONS
   Test out in 
   datasource selector modal
   dateset editor 
   and tab drop down in sqleditor
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org