serenajiang opened a new pull request #15313:
URL: https://github.com/apache/superset/pull/15313


   ### SUMMARY
   Fixing what I think is a typo. This was missed in the `generic_type` -> 
`type_generic` rename, and it caused a fatal error with some dashboards in the 
datasets API after [this 
change](https://github.com/apache/superset/pull/15188/files#diff-f7dd033ada4e47e82f1341b9d7d77c7f0b980bd3c21d54b6e0b4c7e5ad30f3c4L312).
   
   ### TESTING INSTRUCTIONS
   Easiest way to reproduce is probably by editing the code to manually throw 
an exception, but we had dashboards already failing, so I just confirmed this 
fixed the problems I had.
   
   I confirmed this fixed the dashboard we saw problems with.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to