[GitHub] [superset] pkdotson opened a new pull request #15336: refactor: icon to icons for basicerror componenet

[GitBox]

pkdotson opened a new pull request #15336:
URL: https://github.com/apache/superset/pull/15336


   ### SUMMARY
   This pr refactors the basicerror icon to icons.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   before 
   <img width="271" alt="Cannot load filter" 
src="https://user-images.githubusercontent.com/17326228/123161138-e708f580-d423-11eb-8bf2-aa269ce2d293.png";>
   <img width="470" alt="Screen Shot 2021-06-23 at 10 53 33 AM" 
src="https://user-images.githubusercontent.com/17326228/123161494-4e26aa00-d424-11eb-9f72-64874c7428a0.png";>
   after
   <img width="271" alt="Cannot load filter" 
src="https://user-images.githubusercontent.com/17326228/123161163-ee300380-d423-11eb-8d94-dd8b52c1be62.png";>
   <img width="470" alt="Screen Shot 2021-06-23 at 10 53 33 AM" 
src="https://user-images.githubusercontent.com/17326228/123161494-4e26aa00-d424-11eb-9f72-64874c7428a0.png";>
   
   ### TESTING INSTRUCTIONS
   To test you must enable nativefilters feature flags and check the 
filterconfigmodal and filterbox for the basic error alert.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org