michael-s-molina opened a new pull request #15363: URL: https://github.com/apache/superset/pull/15363
### SUMMARY Improves the `Select` component UI/UX - iteration 3. Storybook changes: Interactive Select - Adds the remaining properties - Hides the options control - Shows a radio group with no header, text header, and ControlHeader Page Scroll - Adds a panel to show how the Select behaves when there's a scroll on the page Select component changes: - Shows the loading indicator while scrolling - Improves the error handling - Removes unnecessary `useEffects` - Paginates a few px before the bottom of the scroll for better UX - Adds the `invertSelection` option - Changes the API to only expose single and multiple modes - Removes the usage of `any` from the implementation - Improves the support for pagination Improvements/tasks that will be done in the next iterations: - Add RTL tests @rusackas @geido @villebro @pkdotson @kgabryje @suddjian @zhaoyongjie This component will be used by everyone. Please take the time to learn the API, play with the different controls, review and test. PS: Sometimes the storybook is producing a 404 error. We need to investigate that in another PR and also update the Storybook version. For now, if you find the error, you only need to delete the `.cache` folder inside `node_modules` to make it work. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/70410625/123261304-f7c17600-d4cc-11eb-9a1e-a353749c921a.mov https://user-images.githubusercontent.com/70410625/123261311-fb54fd00-d4cc-11eb-80c9-938aba099702.mov ### TESTING INSTRUCTIONS 1- Start the storybook 2 - Open the Select panels 3 - Test the controls ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
