villebro opened a new pull request #15365:
URL: https://github.com/apache/superset/pull/15365


   ### SUMMARY
   This PR removes support for instant filtering from native filters. Primary 
motivations for the removal are as follows:
   - performance implications of triggering filters with every change
   - problems associated with mixing both instant and non-instant filters
   
   ### AFTER
   Notice the absence of instant filtering options.
   
![image](https://user-images.githubusercontent.com/33317356/123265478-c57f3b00-d503-11eb-9c43-07b1f247b13a.png)
   
   ### BEFORE
   Notice the control "Apply changes instantly":
   
![image](https://user-images.githubusercontent.com/33317356/123265649-ec3d7180-d503-11eb-92c6-535671c34bdd.png)
   
   ### TESTING INSTRUCTIONS
   Local testing + updated tests
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #15067
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to