michael-s-molina opened a new pull request #15373: URL: https://github.com/apache/superset/pull/15373
### SUMMARY - Fixes https://github.com/apache/superset/issues/15322 - Fixes https://github.com/apache/superset/issues/15360 Fixes some regressions introduced in https://github.com/apache/superset/pull/15276: - Fixes the size of the inputs in the modal - Fixes the display of the required message - Fixes the spacing of the filter items in the filter bar - Replaced the required message with an icon in the filter bar - Simplifies the logic of the required checkbox in the modal. If the user checks that a filter has a default value, then the default value is validated. If the user checks the required checkbox, the application automatically checks the default value, which will trigger the validation. @villebro I didn't test the code. I'm sharing to receive feedback and to allow you to test it if you can. I'll test it tomorrow and fill in the before/after videos. PR marked as a draft. @kgabryje @rusackas ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF TODO ### TESTING INSTRUCTIONS TODO ### ADDITIONAL INFORMATION - [x] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
