[GitHub] [superset] john-bodley opened a new issue #15378: Temporal columns et al. are not adhered to when re-syncing column metadata

Thu, 24 Jun 2021 20:28:49 -0700 


john-bodley opened a new issue #15378:
URL: https://github.com/apache/superset/issues/15378


   A clear and concise description of what the bug is.
   
   ### Expected results
   
   When registering a Druid dataset the `__time` field is correctly identified 
as being temporal, however when re-syncing from source the `Is temporal` 
checkbox becomes unchecked. It seems like the logic residing in the 
[alter_new_orm_column](https://github.com/apache/superset/blob/9773aba522e957ed9423045ca153219638a85d2f/superset/db_engine_specs/druid.py#L58-L60)
 function isn't called upon sync.
   
   ### Actual results
   
   The temporal fields et al. defaults aren't adhered to.
   
   #### Screenshots
   
   ##### Before
   
   <img width="870" alt="Screen Shot 2021-06-24 at 8 20 20 PM" 
src="https://user-images.githubusercontent.com/4567245/123364702-0725e980-d5c9-11eb-9328-b073f01ecfbd.png";>
   
   ##### After
   
   <img width="862" alt="Screen Shot 2021-06-24 at 8 20 31 PM" 
src="https://user-images.githubusercontent.com/4567245/123364698-05f4bc80-d5c9-11eb-9f39-b3e4c3c3178d.png";>
   
   #### How to reproduce the bug
   
   1. Go to `/tablemodelview/list/`
   2. Choose a physical table which has a temporal field and click the 'Edit' 
action button.
   3. Click on the `COLUMNS` tab and then the `SYNC COLUMNS FROM SOURCE` button.
   4. Notice that the `Is temporal` checkbox becomes unchecked.
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: `superset version`
   - python version: `python --version`
   - node.js version: `node -v`
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version 
of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to