zhaoyongjie commented on a change in pull request #15279:
URL: https://github.com/apache/superset/pull/15279#discussion_r658450368
##########
File path: superset/common/query_context.py
##########
@@ -130,11 +191,16 @@ def get_query_result(self, query_object: QueryObject) ->
Dict[str, Any]:
if self.enforce_numerical_metrics:
self.df_metrics_to_num(df, query_object)
+ if query_object.time_offset:
+ df, offset_sql = self.processing_time_offset(df, query_object)
+ query += ";\n\n".join(offset_sql)
+ query += ";\n\n"
Review comment:
The purpose of this is to ensure that all SQLs are followed by a
semicolon.
```
main query;
offset1 query;
offset2 query;
offset3 query;
^ append semicolon at end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
