villebro commented on a change in pull request #15385:
URL: https://github.com/apache/superset/pull/15385#discussion_r658671184
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/ColumnSelect.tsx
##########
@@ -103,6 +128,7 @@ export function ColumnSelect({
onChange={onChange}
options={options}
placeholder={t('Select a column')}
+ notFoundContent={t('No columns found')}
Review comment:
Should we make this message display the `currentFilterType` when set,
just in case? Something like "No numerical columns found" if filtering for
numerical columns etc.
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/utils.ts
##########
@@ -20,9 +20,15 @@ import { flatMapDeep } from 'lodash';
import { FormInstance } from 'antd/lib/form';
import React from 'react';
import { CustomControlItem, DatasourceMeta } from
'@superset-ui/chart-controls';
+import { Column, ensureIsArray, GenericDataType } from '@superset-ui/core';
const FILTERS_FIELD_NAME = 'filters';
+export const FILTER_GROUPS = {
+ TIME: ['filter_time', 'filter_timegrain', 'filter_timecolumn'],
Review comment:
nit: would `TEMPORAL` be more accurate? Also, would it be a good idea to
list the supported datatypes instead?
```js
{
filter_time: [GenericDataType.TEMPORAL],
filter_timegrain: [GenericDataType.TEMPORAL],
filter_timecolumn: [GenericDataType.TEMPORAL],
filter_select: [GenericDataType.STRING, GenericDataType.NUMERIC,
GenericDataType.TEMPORAL],
filter_range: [GenericDataType.NUMERIC],
}
```
or similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
