michael-s-molina commented on pull request #15265: URL: https://github.com/apache/superset/pull/15265#issuecomment-868746132
> One small detail to consider... I noticed that the icons are a little high up, vertically. It seems the `anticon` class has a `vertical-align` of `-.125em` for some reason. If I override that with `vertical-align: middle;` it aligns much better with the text. > >  > > While this _sounds_ like a sensible global change, I'm not sure what fallout/misalignments it might cause. We can pus this PR through as is, or stop and poke around at this. Your call. If you want to merge as is, maybe we can make a project board of "Things to try when we have visual regression testing" Someone probably fixed this while changing another requirement. This is the current state with latest `master`: <img width="313" alt="Screen Shot 2021-06-25 at 3 10 04 PM" src="https://user-images.githubusercontent.com/70410625/123467922-78649d00-d5c7-11eb-8389-3731be7ca79a.png";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/70410625/123467922-78649d00-d5c7-11eb-8389-3731be7ca79a.png"](https://user-images.githubusercontent.com/70410625/123467922-78649d00-d5c7-11eb-8389-3731be7ca79a.png"){kind=link}