villebro commented on a change in pull request #15390:
URL: https://github.com/apache/superset/pull/15390#discussion_r659489653
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadeFilterControl/index.tsx
##########
@@ -53,28 +49,26 @@ const CascadeFilterControl:
React.FC<CascadeFilterControlProps> = ({
onFilterSelectionChange,
}) => (
<>
- <StyledFilterControlBox>
- <StyledCaretIcon name="caret-down" />
- <FilterControl
- dataMaskSelected={dataMaskSelected}
- filter={filter}
- directPathToChild={directPathToChild}
- onFilterSelectionChange={onFilterSelectionChange}
- />
- </StyledFilterControlBox>
-
- <StyledCascadeChildrenList>
+ <FilterControl
+ dataMaskSelected={dataMaskSelected}
+ filter={filter}
+ directPathToChild={directPathToChild}
+ onFilterSelectionChange={onFilterSelectionChange}
+ />
+ <StyledDiv>
{filter.cascadeChildren?.map(childFilter => (
- <li key={childFilter.id}>
+ <>
+ <Icons.CaretDownOutlined iconSize="s" />
Review comment:
I personally think the caret is not needed here, as it is just a static
component that occupies a fair amount of vertical space and doesn't really add
a lot of information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
