suddjian commented on a change in pull request #15424:
URL: https://github.com/apache/superset/pull/15424#discussion_r660071860
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -178,14 +174,15 @@ export const selectIndicatorsForChart = (
};
export const selectNativeIndicatorsForChart = (
- nativeFilters: NativeFiltersState,
+ nativeFilters: Filters,
dataMask: DataMaskStateWithId,
chartId: number,
- charts: any,
+ chart: any,
dashboardLayout: Layout,
chartConfiguration: ChartConfiguration = {},
): Indicator[] => {
- const chart = charts[chartId];
+ // no indicators before chart is rendered
+ if (chart.chartStatus !== 'rendered') return [];
Review comment:
This logic should probably be in a render function rather than in a
selector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
