villebro opened a new pull request #15446:
URL: https://github.com/apache/superset/pull/15446


   ### SUMMARY
   When the `DASHBOARD_FILTERS_EXPERIMENTAL` flag is set, the filter config 
modal produces an error due to the experimental filters not being mapped in the 
`FILTER_SUPPORTED_TYPES` map. This changes the flow so that if a filter is not 
mapped in the filter type map, the data type is assumed to be supported.
   
   ### BEFORE
   
![image](https://user-images.githubusercontent.com/33317356/123784847-89235480-d8e0-11eb-8c42-544aab7f9e6e.png)
   
   ### AFTER
   
![image](https://user-images.githubusercontent.com/33317356/123785009-b112b800-d8e0-11eb-9643-5099f39936df.png)
   
   ### TESTING INSTRUCTIONS
   1. Enable the `DASHBOARD_FILTERS_EXPERIMENTAL` feature flag
   2. Open the filter config modal on a dashboard.
   3. See the error
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to