michael-s-molina commented on a change in pull request #15399:
URL: https://github.com/apache/superset/pull/15399#discussion_r660871593
##########
File path:
superset-frontend/spec/javascripts/explore/components/VizTypeControl_spec.jsx
##########
@@ -31,6 +33,9 @@ const defaultProps = {
isModalOpenInit: true,
};
+const waitForEffects = () =>
+ act(() => new Promise(resolve => setTimeout(resolve, 0)));
Review comment:
> As for nesting, I generally agree with KCD but I also don't think the
code here steps into any of the pitfalls in his article, and there's definitely
a convention in this codebase of using `beforeEach` in this way.
The `describe` was heavily used by Enzyme tests. When we migrated to RTL
tests the `describe` was abandoned following KCD best practices. If you look
for RTL files (.test) you'll see that the majority is not using `describe`
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
