[GitHub] [superset] eschutho opened a new pull request #15465: quote column name if db requires

Tue, 29 Jun 2021 14:23:48 -0700 


eschutho opened a new pull request #15465:
URL: https://github.com/apache/superset/pull/15465


   ### SUMMARY
   We were seeing some issues when using Snowflake with column aliases in 
quotes. When creating the dataset, the outer select statement was quoting the 
alias/label but not the column name. Snowflake in particular requires that if 
the original query column name is quoted then any reference to it must also be 
quoted.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before with quotes (snowflake)
   <img width="1332" alt="Screenshot_6_29_21__2_17_PM" 
src="https://user-images.githubusercontent.com/5186919/123869004-4b74fa80-d8e5-11eb-9a9d-919206acd9ff.png";>
   
   Before without quotes (snowflake):
   <img width="1130" alt="Screenshot_6_29_21__2_22_PM" 
src="https://user-images.githubusercontent.com/5186919/123869102-6e071380-d8e5-11eb-8b34-5cdfe553146f.png";>
   
   
   After with quotes (snowflake): 
   <img width="470" alt="Screenshot_6_29_21__12_52_PM" 
src="https://user-images.githubusercontent.com/5186919/123859095-16fb4180-d8d9-11eb-9cc2-55f1eb7f3185.png";>
   <img width="1196" alt="Screenshot_6_29_21__12_53_PM" 
src="https://user-images.githubusercontent.com/5186919/123859115-1e224f80-d8d9-11eb-8e6f-f38f5a35f1ab.png";>
   
   After without quotes (snowflake):
   <img width="458" alt="Screenshot_6_29_21__12_54_PM" 
src="https://user-images.githubusercontent.com/5186919/123859359-65104500-d8d9-11eb-8c55-6180f1754c9f.png";>
   <img width="1083" alt="_DEV__Explore_-_snowflake_with_quotes" 
src="https://user-images.githubusercontent.com/5186919/123859374-6a6d8f80-d8d9-11eb-9214-56312de2776e.png";>
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to