[GitHub] [superset] lyndsiWilliams opened a new pull request #15486: fix: Database connection R6 fixes

Wed, 30 Jun 2021 16:50:45 -0700 


lyndsiWilliams opened a new pull request #15486:
URL: https://github.com/apache/superset/pull/15486


   ### SUMMARY
   Implemented fixes for the following tasks in this [Clubhouse 
ticket](https://app.clubhouse.io/preset/story/18605/db-connection-fixes-r6).
   - header text is jumpy
   - update alignment on info icons
   - update step 3 line height
   - update edit form margins
   - update placeholder text in params
   
   Extra:
   - Fixed translation functions in BigQuery form (I didn't format them 
properly when I implemented them, oops!)
   
   ### SCREENSHOTS / ANIMATED GIF
   #### `header text is jumpy`
   
![headerIsntJumpingAnymore](https://user-images.githubusercontent.com/55605634/124044316-c831d280-d9d2-11eb-9230-91885eb6aec9.gif)
   
   #### `update alignment on info icons`
   <img width="388" alt="alignedTooltip1" 
src="https://user-images.githubusercontent.com/55605634/124044540-468e7480-d9d3-11eb-9077-b69639157a20.png";>
   <img width="240" alt="alignedTooltip2" 
src="https://user-images.githubusercontent.com/55605634/124044545-47bfa180-d9d3-11eb-9e23-47947823b5f0.png";>
   
   #### `update step 3 line height`
   <img width="920" alt="step3lineheight24" 
src="https://user-images.githubusercontent.com/55605634/124044641-763d7c80-d9d3-11eb-9f4a-0877e4bde40a.png";>
   
   #### `update edit form margins` / `update placeholder text in params`
   <img width="920" alt="correctedEditFormSpacing" 
src="https://user-images.githubusercontent.com/55605634/124044701-a127d080-d9d3-11eb-9e1e-f7c8c2fd3a4e.png";>
   
   ### TESTING INSTRUCTIONS
   From the Superset home page:
   - Hover over "Data" in the upper navigation bar
   - Click "Database"
   - Click the "+ Database" button below the navigation bar and to the right
   - Navigation through the database modal and observe the styling described 
above
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to