kgabryje opened a new pull request #15498: URL: https://github.com/apache/superset/pull/15498
### SUMMARY In `DashboardContainer` we recalculated `chartsInScope` only when scopes changed. However, when we deleted a filter and added a new one with the same scope, scopes were equal so we didn't calculate chartsInScope for the new filter. That resulted in `undefined` error. This PR adds filter's ID to scopes so that we sync `chartsInScope` when scopes change and when new filters are created ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://user-images.githubusercontent.com/15073128/124115398-0defa900-da6e-11eb-97c7-1d08df3fd70c.mp4 After: https://user-images.githubusercontent.com/15073128/124115617-5018ea80-da6e-11eb-97cf-5daeb622cec7.mov ### TESTING INSTRUCTIONS 1. Add a native filter 2. Delete that filter and add a new one with the same scope 3. Verify that charts highlighting on filter focus works as expected ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @villebro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
