villebro opened a new pull request #15500:
URL: https://github.com/apache/superset/pull/15500


   ### SUMMARY
   This adds the option to clear emitted cross filters by adding an `onClick` 
to the cross filter indicator.
   
   ### SCREENSHOT
   
![image](https://user-images.githubusercontent.com/33317356/124121585-bb1ded80-da7d-11eb-80a0-4573c2b0e5f7.png)
   
   ### TESTING INSTRUCTIONS
   1. Enable the `DASHBOARD_CROSS_FILTERS` feature flag
   2. create a chart that supports cross filters and check the "emit cross 
filters" control
   3. add the chart to a dashboard
   4. emit a cross filter
   5. Hover on the cross filter indicator, see the updated tooltip and click on 
the indicator to clear emitted filters
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to