john-bodley commented on a change in pull request #14261:
URL: https://github.com/apache/superset/pull/14261#discussion_r662455892
##########
File path: superset-frontend/src/dashboard/actions/hydrate.js
##########
@@ -302,6 +302,13 @@ export const hydrateDashboard = (dashboardData, chartData,
datasourcesData) => (
filterSetsConfig: metadata?.filter_sets_configuration || [],
});
+ if (!metadata) {
+ metadata = {};
+ }
+
+ metadata.show_native_filters =
Review comment:
@simcha90 @amitmiran137 @villebro should this use the
`DASHBOARD_NATIVE_FILTERS` feature flag for defining the fallback rather than
defaulting to `true`? We've seen instances at Airbnb where dashboard native
filters are showing up in the dashboard metadata even though the feature is
disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
