junlincc commented on pull request #14778: URL: https://github.com/apache/superset/pull/14778#issuecomment-872541540
hi @john-bodley @michellethomas i saw that you have reverted this change from locally. thanks for the feedback 🙏 We assume that the reason why a user click "View chart in Explore" is to tweak a specific chart, because all of the "view only" functionalities, including 1) view query 2)view chart details by hovering 3) maximize chart 4) filtering chart can all be done straightly from Dashboard. Under this assumption, "opening Explore from the same window -> making changes in Explore -> saving chart and going back to the same dashboard -> seeing changes appear on original or a new dashboard" seem to be a better/ more simplified workflow than leaving multiple tabs that show different versions of the same dashboard hanging. One quick enhancement to eliminate confusion is to change "View chart in Explore" to "Edit chart in Explore" I apologize if this assumption doesn't make sense to your users and the inconvenience we introduced by the change. As more and more users adopt Superset globally, accommodating to all users from different organizations became harder and harder, which means changes are inevitable. But I'm not sure if this this change is considered as a "breaking change" according to a passed SIP [SIP-57] Proposal for Semantic Versioning, the definition of UI/UX changes is as follow - Changes that removes an existing functionality, such as a chart type or ability to select favorites. (Inconsequential visual changes or small functional changes such as removing a tooltip or the removing the ability to color a label aren't considered breaking changes.) - Changes that break an existing workflow without providing a clear alternative or require user intervention for the alternative to be applied. User may take a while to adapt to the optimized new flow, but the original functionality - opening Explore was not removed by this PR. I would suggest to go with proposed solution 2 without reverting from the main repo. 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
