rusackas commented on a change in pull request #15489:
URL: https://github.com/apache/superset/pull/15489#discussion_r662600779
##########
File path:
superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
##########
@@ -512,11 +535,33 @@ const VizTypeControl = (props: VizTypeControlProps) => {
/>
<DetailsPane>
- <SectionTitle>{selectedVizMetadata?.name}</SectionTitle>
+ <SectionTitle
+ css={css`
+ grid-area: viz-name;
+ `}
+ >
+ {selectedVizMetadata?.name}
Review comment:
silly nit, but it seems like we could conditionally render the
`SectionTitle` in the first place based on this condition, and potentially save
a couple clock cycles of css preprocessing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
