[GitHub] [superset] suddjian opened a new pull request #15520: feat(explore) Viz gallery component tweaks

[GitBox]

suddjian opened a new pull request #15520:
URL: https://github.com/apache/superset/pull/15520


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   - Separates the viz gallery code from the explore control/modal code
   - Tweaks to thumbnail layout: use grid to set space-between and remove 
strange tall thumbnail containers
   - Sort categories (alphabetically + "Other" at the end)
   - Instead of showing the modal on the Add Slice page, show the contents of 
the viz gallery directly (Explore still uses the modal)
   - Fixed a minor bug where after clicking the X, you'd be stuck in a 
category. The search box would still be focused and you could type in it but it 
wouldn't search.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   On the Add Slice page
   <img width="1134" alt="Screen Shot 2021-07-01 at 4 47 44 PM" 
src="https://user-images.githubusercontent.com/1858430/124205256-bb29e780-da95-11eb-93f1-9005a966eb85.png";>
   
   The viz type control in Explore
   <img width="1133" alt="Screen Shot 2021-07-01 at 4 48 11 PM" 
src="https://user-images.githubusercontent.com/1858430/124201157-22429e80-da8c-11eb-9651-75117d2b60bf.png";>
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   1. Go to Add Slice
   2. Go to Explore and change the slice
   3. Search, hit the X, and type again
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org