suddjian commented on a change in pull request #15528:
URL: https://github.com/apache/superset/pull/15528#discussion_r663144097



##########
File path: 
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx
##########
@@ -61,7 +61,13 @@ const StyledTitle = styled.h4`
   padding: 0;
 `;
 
-const StyledIcon = styled(Icon)`
+const StyledEditIcon = styled(Icons.Edit)`

Review comment:
       Since we want the same styles for both icon types, it would probably be 
cleaner to use emotion's `css` style declarations instead of `styled`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to