koszti commented on pull request #15403: URL: https://github.com/apache/superset/pull/15403#issuecomment-873314032
> This code looks good to me, thank you for the awesome contribution! > > Would you mind adding a few tests for the new functionality? @suddjian I added a few tests by https://github.com/apache/superset/pull/15403/commits/6d209378dca90d349b704d3ea05c7d17cd36ba52 and it's passing locally. Can you please approve the CI workflow to run it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
