geido commented on pull request #15303: URL: https://github.com/apache/superset/pull/15303#issuecomment-873625273
First of all, this is looking great! Congrats I wanted to do some manual testing out of curiosity and came up with the following feedback. #### Selected viz type When changing a viz type, the modal shows the correct title and description at the bottom. However, the selection of the category is incorrect and it is not showing the currently selected type.  #### Inconsistent search behaviour When clicking on the search input, the category is automatically reset to the default. However, when clearing up the search the previously selected category gets selected back again. I think the behaviour should be consistent and clearing up should bring you to the default, not the previously selected category.  #### Default order Do we have a default order when searching? Should it be alphabetical?  #### Unnecessary scroll bar Just a minor thing. The scroll bar for the categories is showing up even though there are no other categories.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
