craig-rueda commented on a change in pull request #15296:
URL: https://github.com/apache/superset/pull/15296#discussion_r664926168
##########
File path: superset/app.py
##########
@@ -104,4 +107,12 @@ def load_override_config() -> Union[Dict[Any, Any],
ModuleType]:
class SupersetApp(Flask):
Review comment:
Not sure I agree with this pattern of hanging fields off of the App. A
more widely accepted/established pattern is to use a custom `extension` that
can be added to the Flask app via the `extensions`. We already have a mechanism
for this (extensions.py)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
