eschutho commented on a change in pull request #15403:
URL: https://github.com/apache/superset/pull/15403#discussion_r664953089
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -222,6 +224,7 @@ class SqlEditor extends React.PureComponent {
componentWillUnmount() {
window.removeEventListener('resize', this.handleWindowResize);
+ window.removeEventListener('beforeunload', this.onBeforeUnload.bind(this));
Review comment:
don't think you need the bind here, since this has already been bound
when the method was declared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
