simcha90 edited a comment on pull request #15506:
URL: https://github.com/apache/superset/pull/15506#issuecomment-875420917
Hi @junlincc @michael-s-molina yep, you are right it's good point to wait
for some more feedbacks before merge, I will take it in account for next PRs
About notes, because this PR fix some other behavioral bugs, I'd prefer
create one new PR to fix your notes rather then revert this one, to fix your
notes I have some questions:
**1. About Spacing / Coloring:**
We have here 2 features in one:
a. Adding red colors to filters dependent on the type of filter: like
border for Select Filter or make Range Filter is red for required state - this
feature is not affecting layout, only change color of the filters
b. Adding `Value is required` text and spacing between items - this feature
affecting layout and add spacing, so we have 2 ways here:
- Revert this text for all filters as you proposed in first
- Add this text only when needed and in other cases just remove this space
**2. Bug with initial value I'll create separate PR for it**
@junlincc @michael-s-molina can you please give your input for first item?
And I will create PR ASAP to fix it, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
