ofekisr opened a new pull request #15573: URL: https://github.com/apache/superset/pull/15573
### SUMMARY A better best practice is to put all project dependencies into the requirements file instead of setup.py so adding a new dependency will Imply running pip-compile-multi. When adding a new dependency into setup.py, pip-comiple-multi verify will not detect the change. this PR try to prevent issues like #15527 Actually, I copy the way pip-compile-multi did and you can take another [pip-compile-issue](https://github.com/peterdemin/pip-compile-multi/issues/273) note - before the commit, after moving the packages from setup.py I ran `pip-compile-multi --no-upgrade` to ensure that all requirements files are ok ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
