suddjian commented on pull request #15303: URL: https://github.com/apache/superset/pull/15303#issuecomment-875934104
Thank you both very much for the well-written feedback, paging @junlincc to get product eyes on this. Some notes: - The edge case of non-scrollable scrollbars is pretty unavoidable in a grid-based design like this. At some point before things disappear off the edge of the container, the scrollbar has to appear. I don't think it would be worth the unsavory css margin hacks required to tweak when that occurs. A more responsive design could reduce the impact of this, maybe that would be a good follow-up. - The examples list in its current form is a temporary solution. Ultimately, we'd like to use a carousel or other solution. AntD has these components, but we will need to bump the version to get it working correctly. - I think a de-selected state makes sense. I've opened a PR to add that: #15577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
