betodealmeida commented on a change in pull request #15578:
URL: https://github.com/apache/superset/pull/15578#discussion_r666300591
##########
File path: superset/db_engine_specs/gsheets.py
##########
@@ -33,6 +36,12 @@
SYNTAX_ERROR_REGEX = re.compile('SQLError: near "(?P<server_error>.*?)":
syntax error')
+class GSheetsParametersType(TypedDict):
+ credentials_info: Dict[str, Any]
+ query: Dict[str, Any]
Review comment:
No, it's to pass parameters to configure the engine, eg:
```
gsheets://?list_all_sheets=1
```
This makes the dropdown show not only sheets in the catalog, but all of the
user's sheets.
This can be done in the "extra" session as well, to be clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
