koszti commented on a change in pull request #15403:
URL: https://github.com/apache/superset/pull/15403#discussion_r666628198
##########
File path: superset/db_engine_specs/base.py
##########
@@ -1304,6 +1304,28 @@ def get_column_spec(
)
return None
+ @classmethod
+ def get_cancel_query_payload(cls, cursor: Any, query: Query) -> Any:
Review comment:
the `cursor` is db driver specific, defined in the driver and it's hard
to set anything better than `Any` that remains compatible with every driver.
It's using `Any` in the entire codebase. But please correct me if I'm wrong or
if you have better idea that doesn't require major refactoring of the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
