[GitHub] [superset] andrewbastian opened a new pull request #15608: Chore: update dataset count badge and tash icon sizing

[GitBox]

andrewbastian opened a new pull request #15608:
URL: https://github.com/apache/superset/pull/15608


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Created a `styledComponent` to set hight and center numbers on the 
`count-badge` on `dataset-tabs`. Also added inline 
`css={{...align-items:center}}` to parent div - centers badge and tab-title.
   
   Removed inline `css` from `EditDatasetModals`'s `Icon.Trash`. This Icon now 
matches the sizing of the other `TrashIcon` on the datasets homepage(see 
screenshot).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ####CountBadge
   <img width="1417" alt="Screen Shot 2021-07-08 at 6 57 53 PM" 
src="https://user-images.githubusercontent.com/50464395/125014902-5b968380-e023-11eb-97be-250d08366526.png";>
   
   |ModalTrashIcon | DatasetHompageTrashIcon  |
   |-------|--|
   |     
   <img width="1417" alt="Screen Shot 2021-07-08 at 11 38 36 AM" 
src="https://user-images.githubusercontent.com/50464395/125015082-a7e1c380-e023-11eb-97c9-33159a6d64bd.png";>
     | 
   <img width="1417" alt="Screen Shot 2021-07-08 at 11 30 10 AM" 
src="https://user-images.githubusercontent.com/50464395/125014948-71a44400-e023-11eb-8923-a60b36f3b45b.png";>
    |
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org