eschutho commented on a change in pull request #15619:
URL: https://github.com/apache/superset/pull/15619#discussion_r667128714



##########
File path: 
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -342,6 +342,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> 
= ({
   const dbImages = getDatabaseImages();
   const connectionAlert = getConnectionAlert();
   const isEditMode = !!databaseId;
+  const sortedAvailableDBs = availableDbs?.databases.sort();

Review comment:
       this won't actually sort because the databases are objects... see note 
below.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to