suddjian commented on a change in pull request #15624:
URL: https://github.com/apache/superset/pull/15624#discussion_r667244919
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -116,16 +118,16 @@ const getEntityTitle = (entity: ActivityObject) => {
return entity.item_title || UNTITLED;
};
-const getEntityIconName = (entity: ActivityObject) => {
- if ('sql' in entity) return 'sql';
+const getEntityIcons = (entity: ActivityObject) => {
Review comment:
I think this being plural is confusing. Seems to indicate we are
returning multiple icons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
