michael-s-molina commented on a change in pull request #15630:
URL: https://github.com/apache/superset/pull/15630#discussion_r667877683
##########
File path: superset-frontend/src/dashboard/util/activeAllDashboardFilters.ts
##########
@@ -82,40 +90,65 @@ export const getRelevantDataMask = (
{},
);
+export const isChartAffectedByDataset = (
+ charts: Charts,
+ chartId: number,
+ nativeFilters: Filters,
+ filterId: string | number,
+) => {
+ const chartDatasetId = charts?.[chartId]?.formData?.datasource?.split(
+ '__',
+ )?.[0];
+ const foundDatasetInNativeFilters =
+ nativeFilters[filterId] &&
+ (`${nativeFilters[filterId]?.targets?.[0]?.datasetId}` === chartDatasetId
||
+ !nativeFilters[filterId]?.targets?.[0]?.datasetId);
+ const foundDatasetInCrossFilters =
+ charts?.[filterId]?.formData?.datasource === chartDatasetId ||
+ !charts?.[filterId]?.formData?.datasource;
Review comment:
```suggestion
const datasetId = nativeFilters[filterId]?.targets?.[0]?.datasetId;
const foundDatasetInNativeFilters =
nativeFilters[filterId] &&
(`${datasetId}` === chartDatasetId || !datasetId);
const datasource = charts?.[filterId]?.formData?.datasource;
const foundDatasetInCrossFilters =
datasource === chartDatasetId || !datasource;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
