michael-s-molina commented on pull request #15618:
URL: https://github.com/apache/superset/pull/15618#issuecomment-878452655
@rusackas I just talked to @pkdotson about this. The idea here is just to
simplify the code, removing the double checking of the states.
```
if (status === 'success') {
statusConfig.name = (
<Icons.Check css={theme => StatusIcon(theme, 'running')} />
);
const getColor = (theme: SupersetTheme, status: string) => {
if (status === 'success') return theme.colors.success.base;
```
@pkdotson Is making the changes so please don't merge this yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
