michael-s-molina commented on a change in pull request #15583: URL: https://github.com/apache/superset/pull/15583#discussion_r667969241
########## File path: superset-frontend/src/dashboard/util/replaceUndefinedByNull.ts ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { cloneDeep } from 'lodash'; + +export default function replaceUndefinedByNull(object: Object) { Review comment: I totally agree with the unnecessary cloneDeep. Will fix that. About the JSON serialization/deserialization I prefer the `deepClone` because it's faster. We already have benchmarks on this topic: https://stackoverflow.com/questions/122102/what-is-the-most-efficient-way-to-deep-clone-an-object-in-javascript https://jsben.ch/bWfk9 ########## File path: superset-frontend/src/dashboard/util/replaceUndefinedByNull.ts ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { cloneDeep } from 'lodash'; + +export default function replaceUndefinedByNull(object: Object) { Review comment: I totally agree with the unnecessary `cloneDeep`. Will fix that. About the JSON serialization/deserialization I prefer the `deepClone` because it's faster. We already have benchmarks on this topic: https://stackoverflow.com/questions/122102/what-is-the-most-efficient-way-to-deep-clone-an-object-in-javascript https://jsben.ch/bWfk9 ########## File path: superset-frontend/src/dashboard/util/replaceUndefinedByNull.ts ########## @@ -0,0 +1,31 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { cloneDeep } from 'lodash'; + +export default function replaceUndefinedByNull(object: Object) { Review comment: I totally agree with the unnecessary `cloneDeep`. Will fix that. About the JSON serialization/deserialization I prefer the `cloneDeep` because it's faster. We already have benchmarks on this topic: https://stackoverflow.com/questions/122102/what-is-the-most-efficient-way-to-deep-clone-an-object-in-javascript https://jsben.ch/bWfk9 ########## File path: superset-frontend/src/dataMask/reducer.ts ########## @@ -128,6 +131,7 @@ const dataMaskReducer = produce( [], cleanState, draft, + undefined, Review comment: This was a result of a previous refactor where I had an additional parameter but ended up reverting. Will remove it. Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
