john-bodley opened a new pull request #15648: URL: https://github.com/apache/superset/pull/15648
### SUMMARY We noticed that large dashboards were repeatedly requesting the same datasource metadata regardless of whether multiple slices shared the same datasource. This PR updates the logic (though less pretty) to ensure that when building the mapping of slices by datasource [this](https://github.com/apache/superset/blob/master/superset/models/slice.py#L120-L123) query isn't called unnecessarily. The solution was to merely create a dictionary which is _equivalently_ keyed by `(datasource_type, datasource_id)` from which the datasource object is only fetched once. ### TESTING INSTRUCTIONS Tested with `SQLALCHEMY_ECHO = True` and confirmed that the number of database queries was significantly reduced. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
